Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 667463003: Remove unsupported option 'pageset-repeat-iters' from DRP tests (Closed)

Created:
6 years, 2 months ago by sclittle
Modified:
6 years, 2 months ago
Reviewers:
bengr, bolian
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Remove unsupported option 'pageset-repeat-iters' from DRP tests Using this option causes the tests to fail immediately with an exception, so this option has been removed in order to fix the tests. BUG=423916 Committed: https://crrev.com/994d2564fdce366bb97dc736376bbfd379ec108d Cr-Commit-Position: refs/heads/master@{#300191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sclittle
bengr, bolian: all Thanks in advance
6 years, 2 months ago (2014-10-17 18:02:27 UTC) #2
bolian
lgtm.
6 years, 2 months ago (2014-10-17 18:54:49 UTC) #3
bengr
lgtm
6 years, 2 months ago (2014-10-17 23:41:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667463003/1
6 years, 2 months ago (2014-10-17 23:42:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-18 00:57:52 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-18 00:59:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/994d2564fdce366bb97dc736376bbfd379ec108d
Cr-Commit-Position: refs/heads/master@{#300191}

Powered by Google App Engine
This is Rietveld 408576698