Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 667443002: Fix failure to use shared relro on load from a zip file. (Closed)

Created:
6 years, 2 months ago by simonb (inactive)
Modified:
6 years, 2 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews, erikwright+watch_chromium.org, Anton
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Fix failure to use shared relro on load from a zip file. When loading from a zip file, record the path to the zip file, rather that the name of the item within the zip file, as being the name of the loaded library. Fixes failure to use shared relro, visible in logcat as: E/chromium_android_linker(19916): UseSharedRelro: Could not find libchrome.2192.0.so W/chromium_android_linker(19916): Could not use shared RELRO section for libchrome.2192.0.so Note: load from zip file currently supports only a single shared library within any given zip file. BUG=390618 Committed: https://crrev.com/a6edc5a75e110244ed499da609b34e2b56024560 Cr-Commit-Position: refs/heads/master@{#300124}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/android/java/src/org/chromium/base/library_loader/Linker.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
simonb (inactive)
6 years, 2 months ago (2014-10-17 16:22:52 UTC) #2
rmcilroy
On 2014/10/17 16:22:52, simonb wrote: lgtm, thanks!
6 years, 2 months ago (2014-10-17 16:36:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667443002/1
6 years, 2 months ago (2014-10-17 16:40:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 17:39:44 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 17:40:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6edc5a75e110244ed499da609b34e2b56024560
Cr-Commit-Position: refs/heads/master@{#300124}

Powered by Google App Engine
This is Rietveld 408576698