Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 667423006: Roll gyp r1991:1994 (Closed)

Created:
6 years, 2 months ago by sky
Modified:
6 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll gyp r1991:1994 r1994: Moves warning about invalid targets into 'invalid_targets' in result r1993: Stop checking for duplicate basenames Chromium doesn't care about r1992: Simplify and optimize FindCycles BUG=426892 TEST=none R=scottmg@chromium.org Committed: https://crrev.com/84d0c31b212e09618cfc202a00d58857dfa80d5f Cr-Commit-Position: refs/heads/master@{#301411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
sky
6 years, 2 months ago (2014-10-24 19:07:13 UTC) #1
scottmg
lgtm
6 years, 2 months ago (2014-10-24 19:10:38 UTC) #2
sky
On 2014/10/24 19:10:38, scottmg wrote: > lgtm In case this causes problems I'm going to ...
6 years, 2 months ago (2014-10-24 20:01:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667423006/1
6 years, 1 month ago (2014-10-27 14:44:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 19:33:19 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 19:34:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84d0c31b212e09618cfc202a00d58857dfa80d5f
Cr-Commit-Position: refs/heads/master@{#301411}

Powered by Google App Engine
This is Rietveld 408576698