Issue 667423005: Service Workers: Improve object equality assertion errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 667423005: Service Workers: Improve object equality assertion errors (Closed)

Created:
6 years, 2 months ago by jsbell

Modified:
6 years, 2 months ago

Reviewers:
asanka

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Service Workers: Improve object equality assertion errors Use Object.prototype.toString.call() to get a name for the object being tested, rather than '[object]', to make the error more readable. BUG=374802 R=asanka@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184381

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -4 lines)			Patch
M	LayoutTests/http/tests/resources/testharness-helpers.js	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	LayoutTests/http/tests/serviceworker/cache-match-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/serviceworker/cache-put-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

asanka

On 2014/10/24 18:48:46, jsbell wrote: > asanka@ - WDYT? Nice. LGTM!

6 years, 2 months ago (2014-10-24 18:56:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667423005/1

6 years, 2 months ago (2014-10-24 19:03:15 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-24 20:37:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184381

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages