Issue 6674052: [cros] Fix accelerator keys when using non-US/Latin keyboard layouts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6674052: [cros] Fix accelerator keys when using non-US/Latin keyboard layouts. (Closed)

Created:
9 years, 9 months ago by James Su

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher, satorux1, Ben Goodger (Google), Evan Stade

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[cros] Fix accelerator keys when using non-US/Latin keyboard layouts. BUG=chromium-os:10120 TEST=Switch to Russian keyboard layout, try accelerators like ctrl-t, ctrl-w, etc. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78565

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+128 lines, -2 lines)			Patch
M	ui/base/keycodes/keyboard_code_conversion_gtk.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/base/keycodes/keyboard_code_conversion_gtk.cc	View	2 chunks	+19 lines, -0 lines	0 comments	Download
M	ui/base/keycodes/keyboard_code_conversion_x.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/base/keycodes/keyboard_code_conversion_x.cc	View	3 chunks	+98 lines, -0 lines	0 comments	Download
M	views/events/event_gtk.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

James Su

Hi Ben, Could you please help me review this CL? satorux may not be able ...

9 years, 9 months ago (2011-03-17 07:14:30 UTC) #2

Ben Goodger (Google)

Passing to one of Elliot or Evan since I am swamped.

9 years, 9 months ago (2011-03-17 14:57:20 UTC) #3

Elliot Glaysher

9 years, 9 months ago (2011-03-17 17:44:51 UTC) #4

On 2011/03/17 14:57:20, Ben Goodger wrote:
> Passing to one of Elliot or Evan since I am swamped.

LGTM