Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: net/url_request/url_request_job.cc

Issue 6674042: Make URLRequestHttpJob the only URLRequestJob concerned with FilterContext. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Responded to comments from willchan Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_job.cc
diff --git a/net/url_request/url_request_job.cc b/net/url_request/url_request_job.cc
index 59e63b33beb72c65b7b4068afe8012b4d287fa73..67031ce0544c63935fad7ae66092b0737feb33d3 100644
--- a/net/url_request/url_request_job.cc
+++ b/net/url_request/url_request_job.cc
@@ -121,16 +121,8 @@ bool URLRequestJob::GetResponseCookies(std::vector<std::string>* cookies) {
return false;
}
-bool URLRequestJob::GetContentEncodings(
- std::vector<Filter::FilterType>* encoding_types) {
- return false;
-}
-
-void URLRequestJob::SetupFilter() {
- std::vector<Filter::FilterType> encoding_types;
- if (GetContentEncodings(&encoding_types)) {
- filter_.reset(Filter::Factory(encoding_types, *this));
- }
+Filter* URLRequestJob::SetupFilter() const {
+ return NULL;
}
bool URLRequestJob::IsRedirectResponse(GURL* location,
@@ -457,7 +449,7 @@ void URLRequestJob::NotifyHeadersComplete() {
has_handled_response_ = true;
if (request_->status().is_success()) {
- SetupFilter();
+ filter_.reset(SetupFilter());
// Check if this content appears to be compressible.
std::string mime_type;

Powered by Google App Engine
This is Rietveld 408576698