Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 667353002: Bump Xcode compatibility version from 45 (Xcode 2.4-3.1) to 46 (Xcode 3.2). (Closed)

Created:
6 years, 2 months ago by justincohen
Modified:
5 years, 9 months ago
CC:
gyp-developer_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Bump Xcode compatibility version from 45 (Xcode 2.4-3.1) to 46 (Xcode 3.2). Remove support for xcode_project_version. BUG= R=mark@chromium.org, sdefresne@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/28c00336a403948e871c45f5a872ba050a8311a4

Patch Set 1 #

Patch Set 2 : Test removing compatibility version #

Patch Set 3 : Rebase to gyp #

Patch Set 4 : Put back compatibilityVersion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -21 lines) Patch
M pylib/gyp/generator/xcode.py View 1 2 chunks +0 lines, -3 lines 0 comments Download
M pylib/gyp/xcodeproj_file.py View 1 2 3 1 chunk +1 line, -18 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
justincohen
6 years, 2 months ago (2014-10-22 02:01:51 UTC) #2
sdefresne
Chemistry dog LGTM
6 years, 2 months ago (2014-10-22 08:18:06 UTC) #3
justincohen
Do we need to still set 'compatibilityVersion' at all, and should we still support the ...
6 years, 2 months ago (2014-10-22 14:05:05 UTC) #5
sdefresne
On 2014/10/22 14:05:05, justincohen wrote: > Do we need to still set 'compatibilityVersion' at all, ...
5 years, 9 months ago (2015-02-27 10:07:35 UTC) #6
justincohen
PTAL.
5 years, 9 months ago (2015-03-04 15:01:12 UTC) #9
sdefresne
lgtm
5 years, 9 months ago (2015-03-04 15:03:50 UTC) #10
sdefresne
On 2015/03/04 15:03:50, sdefresne wrote: > lgtm BTW, gyp moved to git instead of svn. ...
5 years, 9 months ago (2015-03-04 15:04:56 UTC) #11
justincohen
mark@ do we need compatibilityVersion at all, anymore?
5 years, 9 months ago (2015-03-10 00:47:10 UTC) #12
Mark Mentovai
If Xcode still sets it when it writes project files, we should too.
5 years, 9 months ago (2015-03-10 04:31:13 UTC) #13
justincohen
I put back the hard coded 'compatibilityVersion' of "Xcode 3.2" (that's what Xcode does now). ...
5 years, 9 months ago (2015-03-10 19:29:41 UTC) #14
Mark Mentovai
LGTM
5 years, 9 months ago (2015-03-10 19:30:30 UTC) #15
justincohen
5 years, 9 months ago (2015-03-10 20:43:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
28c00336a403948e871c45f5a872ba050a8311a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698