Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 667323002: Update protobuff and template to handle text direction (Closed)

Created:
6 years, 2 months ago by mdjones
Modified:
6 years, 1 month ago
Reviewers:
cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update protobuff and template to handle text direction - Add field to distilled_page.proto - Update html template to accept "dir" attribute on body BUG=374404 Committed: https://crrev.com/0fdfe5748a4a0370e2c1b5b2fc90094de97f0a1f Cr-Commit-Position: refs/heads/master@{#301372}

Patch Set 1 : Text directionality fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M components/dom_distiller/core/distiller.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M components/dom_distiller/core/html/dom_distiller_viewer.html View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/proto/distilled_page.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M components/dom_distiller/core/viewer.cc View 7 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mdjones
Please review my changes. Thanks, Matt
6 years, 2 months ago (2014-10-21 23:09:51 UTC) #2
cjhopman
lgtm
6 years, 2 months ago (2014-10-22 22:16:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667323002/1
6 years, 1 month ago (2014-10-27 15:06:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 15:51:51 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 15:52:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fdfe5748a4a0370e2c1b5b2fc90094de97f0a1f
Cr-Commit-Position: refs/heads/master@{#301372}

Powered by Google App Engine
This is Rietveld 408576698