Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Issue 667303002: Revert of Use -s to pass string date to 'adb shell date' command to set date in provision. (Closed)

Created:
6 years, 2 months ago by mattm
Modified:
6 years, 2 months ago
Reviewers:
jbudorick, navabi, zty, yfriedman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Use -s to pass string date to 'adb shell date' command to set date in provision. (patchset #1 id:1 of https://codereview.chromium.org/668013003/) Reason for revert: Broke the same tests mentioned on the bug on existing android bots, ex: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/23612 https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16366 Original issue's description: > Use -s to pass string date to 'adb shell date' command to set date in provision. > > The 'date -u' was not working on N5 devices. The -s option seems to work across > devices. I've tested on N4 and N5. > > BUG=406848 > > Committed: https://crrev.com/e3b2f5071ae50778f07abbc84fc6a9e07e169892 > Cr-Commit-Position: refs/heads/master@{#300542} TBR=zty@chromium.org,jbudorick@chromium.org,yfriedman@google.com,navabi@google.com NOTREECHECKS=true NOTRY=true BUG=406848 Committed: https://crrev.com/6bdf7e45681c9537134f14c97b622e5ee3156a2b Cr-Commit-Position: refs/heads/master@{#300557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/android/provision_devices.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mattm
Created Revert of Use -s to pass string date to 'adb shell date' command to ...
6 years, 2 months ago (2014-10-21 21:56:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667303002/1
6 years, 2 months ago (2014-10-21 21:59:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 22:01:52 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 22:02:43 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bdf7e45681c9537134f14c97b622e5ee3156a2b
Cr-Commit-Position: refs/heads/master@{#300557}

Powered by Google App Engine
This is Rietveld 408576698