chrome/browser/notifications/sync_notifier/chrome_notifier_service_factory.h - Issue 667283002: Standardize usage of virtual/override/final in chrome/browser/notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/sync_notifier/chrome_notifier_service_factory.h

Issue 667283002: Standardize usage of virtual/override/final in chrome/browser/notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/notifications/sync_notifier/chrome_notifier_service_factory.h

diff --git a/chrome/browser/notifications/sync_notifier/chrome_notifier_service_factory.h b/chrome/browser/notifications/sync_notifier/chrome_notifier_service_factory.h

index 2cbf32662be1d0d09ce58e5a7813c6b789909948..66d36cf066ee0f2026e9c674543a168c57d3515c 100644

--- a/chrome/browser/notifications/sync_notifier/chrome_notifier_service_factory.h

+++ b/chrome/browser/notifications/sync_notifier/chrome_notifier_service_factory.h

@@ -34,10 +34,10 @@ class ChromeNotifierServiceFactory : public BrowserContextKeyedServiceFactory {

friend struct DefaultSingletonTraits<ChromeNotifierServiceFactory>;

ChromeNotifierServiceFactory();

- virtual ~ChromeNotifierServiceFactory();

+ ~ChromeNotifierServiceFactory() override;

// BrowserContextKeyedServiceFactory:

- virtual KeyedService* BuildServiceInstanceFor(

+ KeyedService* BuildServiceInstanceFor(

content::BrowserContext* profile) const override;

};

« no previous file with comments | « chrome/browser/notifications/sync_notifier/chrome_notifier_service.h ('k') | no next file » | no next file with comments »