chrome/browser/notifications/notification_object_proxy.h - Issue 667283002: Standardize usage of virtual/override/final in chrome/browser/notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_object_proxy.h

Issue 667283002: Standardize usage of virtual/override/final in chrome/browser/notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_delegate.h ('k') | chrome/browser/notifications/notification_system_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_object_proxy.h

diff --git a/chrome/browser/notifications/notification_object_proxy.h b/chrome/browser/notifications/notification_object_proxy.h

index 937c535f4cffb382350023bb86982437a96c6214..df82d54c807c1dbff0f06d2be75e69f5b9194007 100644

--- a/chrome/browser/notifications/notification_object_proxy.h

+++ b/chrome/browser/notifications/notification_object_proxy.h

@@ -28,16 +28,16 @@ class NotificationObjectProxy

scoped_ptr<content::DesktopNotificationDelegate> delegate);

// NotificationDelegate implementation.

- virtual void Display() override;

- virtual void Error() override;

- virtual void Close(bool by_user) override;

- virtual void Click() override;

- virtual std::string id() const override;

+ void Display() override;

+ void Error() override;

+ void Close(bool by_user) override;

+ void Click() override;

+ std::string id() const override;

protected:

friend class base::RefCountedThreadSafe<NotificationObjectProxy>;

- virtual ~NotificationObjectProxy();

+ ~NotificationObjectProxy() override;

private:

scoped_ptr<content::DesktopNotificationDelegate> delegate_;