Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 667263004: Remove [[PROTOTYPE]] from ObjectToStringHarmony (Closed)

Created:
6 years, 2 months ago by caitp (gmail)
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove [[PROTOTYPE]] from ObjectToStringHarmony harmony-tostring needs to emulate InstallFunctions --- InstallFunctions will fail in Debug builds because the `toString` property already exists in Object.prototype. The fix is to add some of the other features from InstallFunctions() to the setup of ObjectToStringHarmony. R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/harmony-tostring.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
caitp (gmail)
On 2014/10/22 12:28:15, caitp wrote: > mailto:caitpotter88@gmail.com changed reviewers: > + mailto:dslomov@chromium.org, mailto:rossberg@chromium.org (I'm still ...
6 years, 2 months ago (2014-10-22 12:28:49 UTC) #2
caitp (gmail)
PTAL
6 years, 2 months ago (2014-10-22 12:29:23 UTC) #3
Dmitry Lomov (no reviews)
lgtm
6 years, 2 months ago (2014-10-22 12:57:44 UTC) #4
Dmitry Lomov (no reviews)
6 years, 2 months ago (2014-10-22 14:06:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24808 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698