Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 667263002: Add layout test for first-letter and render quote. (Closed)

Created:
6 years, 2 months ago by dsinclair
Modified:
6 years, 2 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Add layout test for first-letter and render quote. BUG=424914 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184216

Patch Set 1 #

Patch Set 2 : Rebase to master #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
A LayoutTests/fast/css/first-letter-render-quote.html View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/first-letter-render-quote-expected.html View 1 2 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dsinclair
PTAL.
6 years, 2 months ago (2014-10-22 17:10:16 UTC) #2
Xianzhu
https://codereview.chromium.org/667263002/diff/20001/LayoutTests/fast/css/first-letter-render-quote-expected.html File LayoutTests/fast/css/first-letter-render-quote-expected.html (right): https://codereview.chromium.org/667263002/diff/20001/LayoutTests/fast/css/first-letter-render-quote-expected.html#newcode3 LayoutTests/fast/css/first-letter-render-quote-expected.html:3: html, body { margin-left: 0; } Why setting only ...
6 years, 2 months ago (2014-10-22 17:39:25 UTC) #3
Xianzhu
If this is to test a crash, please add 'passes if no crash' in the ...
6 years, 2 months ago (2014-10-22 17:44:34 UTC) #4
dsinclair
On 2014/10/22 17:44:34, Xianzhu wrote: > If this is to test a crash, please add ...
6 years, 2 months ago (2014-10-22 17:54:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667263002/40001
6 years, 2 months ago (2014-10-22 17:55:56 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 19:58:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 184216

Powered by Google App Engine
This is Rietveld 408576698