Issue 66723020: Merged r17459, r17462, r17474 into 3.21 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 66723020: Merged r17459, r17462, r17474 into 3.21 branch. (Closed)

Created:
7 years, 1 month ago by Jakob Kummerow

Modified:
7 years, 1 month ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.21

Visibility:
Public.

More Reviews

Description

Merged r17459, r17462, r17474 into 3.21 branch. Add missing negative dictionary lookup to NonexistentHandlerFrontend Restore intended LoadIC behavior for JSBuiltinsObject Proper fix for the issue exposed by r17459 BUG=v8:2980 R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17650

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+208 lines, -245 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	6 chunks	+23 lines, -49 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	7 chunks	+28 lines, -54 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	6 chunks	+23 lines, -52 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/stub-cache.h	View	4 chunks	+32 lines, -2 lines	0 comments	Download
M	src/stub-cache.cc	View	2 chunks	+37 lines, -3 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	7 chunks	+28 lines, -57 lines	0 comments	Download
A +	test/mjsunit/regress/regress-2980.js	View	1 chunk	+30 lines, -21 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

7 years, 1 month ago (2013-11-12 14:33:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r17650 (presubmit successful).

Expand Messages | Collapse Messages