Remove deprecated setIsOpaque() API from SkBitmap.

Remove deprecated setIsOpaque() API from SkBitmap.

Clients we care (Blink, Chromium) were updated, so we can remove this now.

BUG=None
R=reed@google.com,bsalomon@google.com

Committed: http://code.google.com/p/skia/source/detail?r=12251

[tfarina, 2013-11-12 01:31:44]

Is it OK to remove this now?

[reed1, 2013-11-12 16:07:49]

Unfortunately, I think we still have callers...

./cc/resources/bitmap_skpicture_content_layer_updater.cc:30: 
bitmap_.setIsOpaque(updater_->layer_is_opaque());
./chrome/browser/media/desktop_media_picker_model.cc:71: 
result.setIsOpaque(true);
./content/browser/renderer_host/render_widget_host_view_android.cc:1308: 
bitmap->setIsOpaque(true);
./content/browser/renderer_host/render_widget_host_view_aura.cc:1905: 
bitmap->setIsOpaque(true);
./content/browser/renderer_host/render_widget_host_view_browsertest.cc:596:   
bitmap.setIsOpaque(true);
./content/renderer/pepper/ppb_image_data_impl.cc:201: 
const_cast<SkBitmap&>(bitmap).setIsOpaque(false);
./content/renderer/pepper/ppb_image_data_impl.cc:276:   
skia_bitmap_.setIsOpaque(false);
./skia/ext/bitmap_platform_device_android.cc:15:   
bitmap.setIsOpaque(is_opaque);
./skia/ext/bitmap_platform_device_android.cc:44:  bitmap.setIsOpaque(is_opaque);
./skia/ext/bitmap_platform_device_android.cc:94: 
bitmap_.setIsOpaque(is_opaque);
./skia/ext/bitmap_platform_device_linux.cc:94:  bitmap.setIsOpaque(is_opaque);
./skia/ext/bitmap_platform_device_linux.cc:201:  bitmap_.setIsOpaque(is_opaque);
./skia/ext/bitmap_platform_device_mac.cc:142:  bitmap.setIsOpaque(is_opaque);
./skia/ext/bitmap_platform_device_mac.cc:294:  bitmap_.setIsOpaque(is_opaque);
./skia/ext/bitmap_platform_device_win.cc:176:  bitmap.setIsOpaque(is_opaque);
./skia/ext/bitmap_platform_device_win.cc:350:  bitmap_.setIsOpaque(is_opaque);
./skia/ext/image_operations.cc:458:  result.setIsOpaque(img.isOpaque());
./skia/ext/image_operations.cc:526:  result.setIsOpaque(source.isOpaque());
./third_party/GTM/XcodePlugin/XcodeHeaders/DevToolsInterface.h:19269:-
(void)setIsOpaque:(BOOL)fp8;
./third_party/skia/include/core/SkBitmap.h:195:    void setIsOpaque(bool opaque)
{
./third_party/skia/include/core/SkBitmap.h:243:     *  this (isOpaque,
setIsOpaque). Only call this if you need to compute this
./ui/gfx/codec/png_codec.cc:468:  bitmap->setIsOpaque(state.is_opaque);
./ui/gfx/image/image_unittest.cc:542:  bitmap.setIsOpaque(false);
./ui/gfx/skbitmap_operations.cc:566:  shifted.setIsOpaque(false);
./ui/gfx/skbitmap_operations.cc:723:  opaque_bitmap.setIsOpaque(true);
./ui/gfx/skbitmap_operations_unittest.cc:69:  shifted.setIsOpaque(false);
./ui/surface/accelerated_surface_transformer_win_unittest.cc:49: 
result.setIsOpaque(true);
./ui/surface/accelerated_surface_win.cc:529:  bitmap->setIsOpaque(true);

[tfarina, 2013-11-12 16:32:29]

Which chromium revision is that? git gs for setIsOpaque in Chromium returned
zero entries for me.

Same in cs.chromium.org.

https://code.google.com/p/chromium/codesearch#search/&q=setIsOpaque&sq=packag...

[reed1, 2013-11-12 16:55:29]

doh! my tree was 'unmanged', which means I was mysteriously out of date.

lgtm

[commit-bot: I haz the power, 2013-11-12 17:39:55]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/66723017/40003

[commit-bot: I haz the power, 2013-11-12 18:16:37]

Change committed as 12251

[scroggo, 2013-11-13 19:37:48]

We still need to update Android, which calls setIsOpaque.

[tfarina, 2013-11-13 22:01:18]

On 2013/11/13 19:37:48, scroggo wrote:
> We still need to update Android, which calls setIsOpaque.

Do I need to fix Android myself? I haven't checkout android code in years.

[reed1, 2013-11-13 22:05:57]

On 2013/11/13 22:01:18, tfarina wrote:
> On 2013/11/13 19:37:48, scroggo wrote:
> > We still need to update Android, which calls setIsOpaque.
> 
> Do I need to fix Android myself? I haven't checkout android code in years.

We have "people" who take care of that sort of thing :)
You're good.