Fixes 1 pixel shift of text rendering on CrOS and Linux.

ui/gfx/render_text.cc

Index: ui/gfx/render_text.cc
diff --git a/ui/gfx/render_text.cc b/ui/gfx/render_text.cc
index 2c062a5555d355965da55061f17206d9de6bc439..b35e1dcfe525da4fb8103062756e9ee8759c5367 100644
--- a/ui/gfx/render_text.cc
+++ b/ui/gfx/render_text.cc
@@ -62,8 +62,13 @@ int DetermineBaselineCenteringText(const Rect& display_rect,
   const int baseline = font_list.GetBaseline();
   const int cap_height = font_list.GetCapHeight();
   const int internal_leading = baseline - cap_height;
-  const int baseline_shift =
-      (display_height - cap_height) / 2 - internal_leading;
+  // Some platforms don't support getting the cap height, and simply return

[msw, 2013/11/11 18:07:26]

This and your prior CL (http://crrev.com/59873002) both restore text height
centering instead of cap height centering for Pango. Doesn't that effectively
undo this part of you original CL:
https://codereview.chromium.org/25039002/diff/1099001/ui/gfx/platform_font_pa...
Should you undo the changes in these two latest CLs and that small part of the
original CL to keep the same behavior? Or do some fonts (on other platforms?)
actually not provide an internal_leading, and these coordinated workarounds
actually support some additional cases?

+  // the entire font ascent from GetCapHeight().  Centering the ascent makes
+  // the font look too low, so if GetCapHeight() returns the ascent, center
+  // the entire font height instead.
+  const int space =
+      display_height - ((internal_leading != 0) ? cap_height : font_height);
+  const int baseline_shift = space / 2 - internal_leading;
   return baseline + std::max(min_shift, std::min(max_shift, baseline_shift));
 }