Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 667223003: Update iOS grit whitelist and ifdef out some unused resources. (Closed)

Created:
6 years, 2 months ago by lliabraa
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update iOS grit whitelist and remove dep on unused resources. The iOS whitelist was incomplete but things were still working due to a bug in grit where some resources are being added even if they are not in the whitelist. The fix for that grit bug is in https://chromiumcodereview.appspot.com/669763002/ Also, the dependency on ui/native_theme is removed from iOS because it is unused, allowing the resources to be omitted from the .pak file. BUG=None Committed: https://crrev.com/302dbd2dcc4f2f2f4690b3da284d6405ed7955c8 Cr-Commit-Position: refs/heads/master@{#302106}

Patch Set 1 #

Patch Set 2 : remove unused from whitelist; back out avatar changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -7 lines) Patch
M build/ios/grit_whitelist.txt View 1 3 chunks +105 lines, -6 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
lliabraa
6 years, 2 months ago (2014-10-21 18:53:13 UTC) #2
rohitrao (ping after 24h)
Whitelist and gypi changes LGTM I would prefer to remove the chrome/browser/profiles changes from this ...
6 years, 2 months ago (2014-10-21 20:40:28 UTC) #3
lliabraa
Okay...avatar changes removed.
6 years, 2 months ago (2014-10-23 18:05:10 UTC) #4
rohitrao (ping after 24h)
lgtm
6 years, 2 months ago (2014-10-23 18:08:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667223003/20001
6 years, 1 month ago (2014-10-30 17:20:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-30 18:03:28 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 18:04:05 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/302dbd2dcc4f2f2f4690b3da284d6405ed7955c8
Cr-Commit-Position: refs/heads/master@{#302106}

Powered by Google App Engine
This is Rietveld 408576698