Issue 667213003: Merge 183859 "Place RefPtr for protection not in internalAbort()..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 667213003: Merge 183859 "Place RefPtr for protection not in internalAbort()..." (Closed)

Created:
6 years, 2 months ago by tyoshino (SeeGerritForStatus)

Modified:
6 years, 2 months ago

Reviewers:
tyoshino (SeeGerritForStatus)

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/branches/chromium/2171/

Project:
blink

Visibility:
Public.

Merge 183859 "Place RefPtr for protection not in internalAbort()..." > Place RefPtr for protection not in internalAbort() but in its caller. > > We have RefPtr for preventing XHR from being destroyed in > internalAbort(). But we're touching XHR's member variables in the caller > of internalAbort(). We must have the RefPtr for protection there. > > BUG=421504 > > Review URL: https://codereview.chromium.org/663693003 TBR=tyoshino@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184241

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	Source/core/xml/XMLHttpRequest.cpp	View		7 chunks	+16 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

tyoshino (SeeGerritForStatus)

6 years, 2 months ago (2014-10-23 08:19:31 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r184241.