Support touch icon in FaviconHelper

content/renderer/render_view.cc

Index: content/renderer/render_view.cc
diff --git a/content/renderer/render_view.cc b/content/renderer/render_view.cc
index 404a5ec37cba667dddcee3546409d6a26ba7d360..a8f127dbfbec57911c14171347113e143f75a803 100644
--- a/content/renderer/render_view.cc
+++ b/content/renderer/render_view.cc
@@ -2121,9 +2121,14 @@ void RenderView::didStopLoading() {
   // displayed when done loading. Ideally we would send notification when
   // finished parsing the head, but webkit doesn't support that yet.
   // The feed discovery code would also benefit from access to the head.
+
+  // TODO : Get both favicon and touch icon url, and send them to the browser.

[sky, 2011/03/22 19:48:48]

You should only do this if the browser cares about them. You'll need something
similar to defaults, or perhaps you can pass it down as a pref. I'm not sure
what's the preferred approach.

[michaelbai, 2011/03/22 23:59:03]

I will revisit it after I get the webkit part done.

Thanks

   GURL favicon_url(webview()->mainFrame()->favIconURL());
-  if (!favicon_url.is_empty())
-    Send(new ViewHostMsg_UpdateFaviconURL(routing_id_, page_id_, favicon_url));
+  if (!favicon_url.is_empty()) {
+    std::vector<FaviconURL> urls;
+    urls.push_back(FaviconURL(favicon_url, FAVICON));
+    Send(new ViewHostMsg_UpdateFaviconURL(routing_id_, page_id_, urls));
+  }
 
   AddGURLSearchProvider(webview()->mainFrame()->openSearchDescriptionURL(),
                         ViewHostMsg_PageHasOSDD_Type::Autodetected());
@@ -3339,10 +3344,9 @@ void RenderView::didReceiveTitle(WebFrame* frame, const WebString& title) {
 
 void RenderView::didChangeIcons(WebFrame* frame) {
   if (!frame->parent()) {
-    Send(new ViewHostMsg_UpdateFaviconURL(
-        routing_id_,
-        page_id_,
-        frame->favIconURL()));
+    std::vector<FaviconURL> urls;
+    urls.push_back(FaviconURL(frame->favIconURL(), FAVICON));
+    Send(new ViewHostMsg_UpdateFaviconURL(routing_id_, page_id_, urls));
   }
 }