Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 667173002: Add instructions to mojo README to cover installing build dependencies. (Closed)

Created:
6 years, 2 months ago by Matt Perry
Modified:
6 years, 2 months ago
Reviewers:
jamesr
Base URL:
https://github.com/domokit/mojo.git@master
Visibility:
Public.

Description

Add instructions to mojo README to cover installing build dependencies. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0060e3883cf1c5fb57acf55ebbd7d1946b6b8442

Patch Set 1 #

Patch Set 2 : no owners #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M README.md View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Matt Perry
Reviews.. Am I doing this right? It wouldn't let me upload without an OWNERS file. ...
6 years, 2 months ago (2014-10-21 15:46:17 UTC) #2
jamesr
You are doing this right, but we aren't open for business in this repo yet. ...
6 years, 2 months ago (2014-10-21 15:47:14 UTC) #3
jamesr
You are doing this right, but we aren't open for business in this repo yet. ...
6 years, 2 months ago (2014-10-21 15:47:15 UTC) #4
jamesr
I added a root OWNERS file. The README.md change lgtm. We'll send an announcement that ...
6 years, 2 months ago (2014-10-21 19:43:48 UTC) #5
jamesr
We're good now. Wanna try pushing the README.md change to make sure it works?
6 years, 2 months ago (2014-10-21 20:17:54 UTC) #6
Matt Perry
6 years, 2 months ago (2014-10-21 20:35:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0060e3883cf1c5fb57acf55ebbd7d1946b6b8442 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698