DevTools: Do not toggle line styles unless necessary in script editor.

DevTools: Do not toggle line styles unless necessary in script editor.

R=lushnikov

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184272

[vsevik, 2014-10-21 15:26:52]

PTAL

[lushnikov, 2014-10-22 11:23:43]

can we possibly patch this on the side of CMTE?

https://codereview.chromium.org/667163002/diff/1/Source/devtools/front_end/so...
File Source/devtools/front_end/sources/JavaScriptSourceFrame.js (right):

https://codereview.chromium.org/667163002/diff/1/Source/devtools/front_end/so...
Source/devtools/front_end/sources/JavaScriptSourceFrame.js:781: if
(!lineHasMapping || this._hasLineWithoutMapping)
if (this._hasLineWithoutMapping)

[vsevik, 2014-10-23 12:41:05]

On 2014/10/22 11:23:43, lushnikov wrote:
> can we possibly patch this on the side of CMTE?

Yes, but it is still slow (code mirror stores line classes as strings and we
need to run regexes all the time), so I kept both guards.

>
https://codereview.chromium.org/667163002/diff/1/Source/devtools/front_end/so...
> Source/devtools/front_end/sources/JavaScriptSourceFrame.js:781: if
> (!lineHasMapping || this._hasLineWithoutMapping)
> if (this._hasLineWithoutMapping)

Done

[lushnikov, 2014-10-23 12:54:06]

Great code, thank you.
LGTM.

[vsevik, 2014-10-23 12:54:45]

The CQ bit was checked by vsevik@chromium.org

[commit-bot: I haz the power, 2014-10-23 12:55:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/667163002/40001

[commit-bot: I haz the power, 2014-10-23 14:40:25]

Committed patchset #3 (id:40001) as 184272