extensions/shell/renderer/shell_content_renderer_client.cc - Issue 667153007: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/renderer/shell_content_renderer_client.cc

Issue 667153007: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/shell/renderer/shell_content_renderer_client.h ('k') | extensions/shell/renderer/shell_extensions_renderer_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/shell/renderer/shell_content_renderer_client.cc

diff --git a/extensions/shell/renderer/shell_content_renderer_client.cc b/extensions/shell/renderer/shell_content_renderer_client.cc

index c6504210aa52a4262716b548fc2852f47de7d66c..487731d93cad67a7b4f5321fe6fed172c311116a 100644

--- a/extensions/shell/renderer/shell_content_renderer_client.cc

+++ b/extensions/shell/renderer/shell_content_renderer_client.cc

@@ -39,11 +39,10 @@ class ShellFrameHelper

public:

ShellFrameHelper(content::RenderFrame* render_frame,

Dispatcher* extension_dispatcher);

- virtual ~ShellFrameHelper();

+ ~ShellFrameHelper() override;

// RenderFrameObserver implementation.

- virtual void WillReleaseScriptContext(v8::Handle<v8::Context>,

- int world_id) override;

+ void WillReleaseScriptContext(v8::Handle<v8::Context>, int world_id) override;

private:

Dispatcher* extension_dispatcher_;