extensions/shell/browser/shell_extension_system_factory.h - Issue 667153007: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_extension_system_factory.h

Issue 667153007: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/shell/browser/shell_extension_host_delegate.h ('k') | extensions/shell/browser/shell_extension_web_contents_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/shell/browser/shell_extension_system_factory.h

diff --git a/extensions/shell/browser/shell_extension_system_factory.h b/extensions/shell/browser/shell_extension_system_factory.h

index 516cec2bfbe60f3ac892a1ac4e0c4e534012af8a..5478d81628b93e531d415dedd5d429316165ac93 100644

--- a/extensions/shell/browser/shell_extension_system_factory.h

+++ b/extensions/shell/browser/shell_extension_system_factory.h

@@ -14,7 +14,7 @@ namespace extensions {

class ShellExtensionSystemFactory : public ExtensionSystemProvider {

public:

// ExtensionSystemProvider implementation:

- virtual ExtensionSystem* GetForBrowserContext(

+ ExtensionSystem* GetForBrowserContext(

content::BrowserContext* context) override;

static ShellExtensionSystemFactory* GetInstance();

@@ -23,14 +23,14 @@ class ShellExtensionSystemFactory : public ExtensionSystemProvider {

friend struct DefaultSingletonTraits<ShellExtensionSystemFactory>;

ShellExtensionSystemFactory();

- virtual ~ShellExtensionSystemFactory();

+ ~ShellExtensionSystemFactory() override;

// BrowserContextKeyedServiceFactory implementation:

- virtual KeyedService* BuildServiceInstanceFor(

+ KeyedService* BuildServiceInstanceFor(

content::BrowserContext* context) const override;

- virtual content::BrowserContext* GetBrowserContextToUse(

+ content::BrowserContext* GetBrowserContextToUse(

content::BrowserContext* context) const override;

- virtual bool ServiceIsCreatedWithBrowserContext() const override;

+ bool ServiceIsCreatedWithBrowserContext() const override;

DISALLOW_COPY_AND_ASSIGN(ShellExtensionSystemFactory);

};