tools/gn/ninja_target_writer_unittest.cc - Issue 667143003: Standardize usage of virtual/override/final in tools/gn/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_target_writer_unittest.cc

Issue 667143003: Standardize usage of virtual/override/final in tools/gn/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/ninja_target_writer_unittest.cc

diff --git a/tools/gn/ninja_target_writer_unittest.cc b/tools/gn/ninja_target_writer_unittest.cc

index 31c58dc5804fa520e1fde3c6c27bb4765778bdf8..1d4a10e1bab87916ebd12237dffe18a738d20cd9 100644

--- a/tools/gn/ninja_target_writer_unittest.cc

+++ b/tools/gn/ninja_target_writer_unittest.cc

@@ -19,7 +19,7 @@ class TestingNinjaTargetWriter : public NinjaTargetWriter {

: NinjaTargetWriter(target, out) {

}

- virtual void Run() OVERRIDE {}

+ void Run() OVERRIDE {}

// Make this public so the test can call it.

OutputFile WriteInputDepsStampAndGetDep(

« tools/gn/action_target_generator.h ('K') | « tools/gn/ninja_group_target_writer.h ('k') | tools/gn/parse_tree.h » ('j') | no next file with comments »