Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: tools/gn/loader.h

Issue 667143003: Standardize usage of virtual/override/final in tools/gn/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/loader.h
diff --git a/tools/gn/loader.h b/tools/gn/loader.h
index 29204ae65ef884743ae332d3ed9011a8e58fc227..2d1588d7208badfba2ed6e5f99e7c10a1d582e72 100644
--- a/tools/gn/loader.h
+++ b/tools/gn/loader.h
@@ -82,13 +82,12 @@ class LoaderImpl : public Loader {
LoaderImpl(const BuildSettings* build_settings);
// Loader implementation.
- virtual void Load(const SourceFile& file,
- const LocationRange& origin,
- const Label& toolchain_name) OVERRIDE;
- virtual void ToolchainLoaded(const Toolchain* toolchain) OVERRIDE;
- virtual Label GetDefaultToolchain() const OVERRIDE;
- virtual const Settings* GetToolchainSettings(
- const Label& label) const OVERRIDE;
+ void Load(const SourceFile& file,
+ const LocationRange& origin,
+ const Label& toolchain_name) OVERRIDE;
+ void ToolchainLoaded(const Toolchain* toolchain) OVERRIDE;
+ Label GetDefaultToolchain() const OVERRIDE;
+ const Settings* GetToolchainSettings(const Label& label) const OVERRIDE;
// Sets the message loop corresponding to the main thread. By default this
// class will use the thread active during construction, but there is not
@@ -115,7 +114,7 @@ class LoaderImpl : public Loader {
struct LoadID;
struct ToolchainRecord;
- virtual ~LoaderImpl();
+ ~LoaderImpl() override;
// Schedules the input file manager to load the given file.
void ScheduleLoadFile(const Settings* settings,

Powered by Google App Engine
This is Rietveld 408576698