Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: tools/gn/target.h

Issue 667143003: Standardize usage of virtual/override/final in tools/gn/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_TARGET_H_ 5 #ifndef TOOLS_GN_TARGET_H_
6 #define TOOLS_GN_TARGET_H_ 6 #define TOOLS_GN_TARGET_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 enum DepsIterationType { 46 enum DepsIterationType {
47 DEPS_ALL, // Iterates through all public, private, and data deps. 47 DEPS_ALL, // Iterates through all public, private, and data deps.
48 DEPS_LINKED, // Iterates through all non-data dependencies. 48 DEPS_LINKED, // Iterates through all non-data dependencies.
49 }; 49 };
50 50
51 typedef std::vector<SourceFile> FileList; 51 typedef std::vector<SourceFile> FileList;
52 typedef std::vector<std::string> StringVector; 52 typedef std::vector<std::string> StringVector;
53 53
54 Target(const Settings* settings, const Label& label); 54 Target(const Settings* settings, const Label& label);
55 virtual ~Target(); 55 ~Target() override;
56 56
57 // Returns a string naming the output type. 57 // Returns a string naming the output type.
58 static const char* GetStringForOutputType(OutputType type); 58 static const char* GetStringForOutputType(OutputType type);
59 59
60 // Item overrides. 60 // Item overrides.
61 virtual Target* AsTarget() OVERRIDE; 61 Target* AsTarget() OVERRIDE;
62 virtual const Target* AsTarget() const OVERRIDE; 62 const Target* AsTarget() const OVERRIDE;
63 virtual bool OnResolved(Err* err) OVERRIDE; 63 bool OnResolved(Err* err) OVERRIDE;
64 64
65 OutputType output_type() const { return output_type_; } 65 OutputType output_type() const { return output_type_; }
66 void set_output_type(OutputType t) { output_type_ = t; } 66 void set_output_type(OutputType t) { output_type_ = t; }
67 67
68 // Can be linked into other targets. 68 // Can be linked into other targets.
69 bool IsLinkable() const; 69 bool IsLinkable() const;
70 70
71 // Can have dependencies linked in. 71 // Can have dependencies linked in.
72 bool IsFinal() const; 72 bool IsFinal() const;
73 73
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 const Toolchain* toolchain_; 309 const Toolchain* toolchain_;
310 310
311 // Output files. Null until the target is resolved. 311 // Output files. Null until the target is resolved.
312 OutputFile link_output_file_; 312 OutputFile link_output_file_;
313 OutputFile dependency_output_file_; 313 OutputFile dependency_output_file_;
314 314
315 DISALLOW_COPY_AND_ASSIGN(Target); 315 DISALLOW_COPY_AND_ASSIGN(Target);
316 }; 316 };
317 317
318 #endif // TOOLS_GN_TARGET_H_ 318 #endif // TOOLS_GN_TARGET_H_
OLDNEW
« tools/gn/action_target_generator.h ('K') | « tools/gn/setup.h ('k') | tools/gn/toolchain.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698