Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2129)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java

Issue 667143002: [aw] Software mode tests for fullscreen API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fixPowerBlockerNonMedia
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java
index a189e29aeb77bd9fc926aa0dd54a48fdaeb91cc9..6b569b8542ae6e19e1231df0f35bd6592943424e 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java
@@ -66,8 +66,11 @@ public class AwContentViewClient extends ContentViewClient implements ContentVid
@Override
public void enterFullscreenVideo(View videoView) {
- // enterFullscreenVideo will only be called after enterFullscreen.
- assert mCustomView != null;
+ if (mCustomView == null) {
boliu 2014/10/22 02:01:02 This should be a content level fix then. Why is co
Ignacio Solla 2014/10/22 09:32:16 Those are all good questions and suggestions. I ha
+ // enterFullscreenVideo will only be called after enterFullscreen, but
+ // in this case exitFullscreen has been invoked in between them.
+ return;
+ }
mCustomView.addView(videoView, 0);
}

Powered by Google App Engine
This is Rietveld 408576698