Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 66713002: Get rid of {Enable|Disable|ChromeCaptivePortalDetector flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restored blank line. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <iterator> 8 #include <iterator>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 181 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
182 // Secure shell can be used on ChromeOS for forwarding the TCP port opened by 182 // Secure shell can be used on ChromeOS for forwarding the TCP port opened by
183 // debug stub to a remote machine. Since secure shell uses NaCl, we provide 183 // debug stub to a remote machine. Since secure shell uses NaCl, we provide
184 // an option to switch off its debugging. 184 // an option to switch off its debugging.
185 { IDS_NACL_DEBUG_MASK_CHOICE_EXCLUDE_UTILS, 185 { IDS_NACL_DEBUG_MASK_CHOICE_EXCLUDE_UTILS,
186 switches::kNaClDebugMask, "!*://*/*ssh_client.nmf" }, 186 switches::kNaClDebugMask, "!*://*/*ssh_client.nmf" },
187 { IDS_NACL_DEBUG_MASK_CHOICE_INCLUDE_DEBUG, 187 { IDS_NACL_DEBUG_MASK_CHOICE_INCLUDE_DEBUG,
188 switches::kNaClDebugMask, "*://*/*debug.nmf" } 188 switches::kNaClDebugMask, "*://*/*debug.nmf" }
189 }; 189 };
190 190
191 #if defined(OS_CHROMEOS)
192
193 const Experiment::Choice kChromeCaptivePortalDetectionChoices[] = {
194 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
195 { IDS_FLAGS_CHROME_CAPTIVE_PORTAL_DETECTOR,
196 chromeos::switches::kEnableChromeCaptivePortalDetector, "" },
197 { IDS_FLAGS_SHILL_CAPTIVE_PORTAL_DETECTOR,
198 chromeos::switches::kDisableChromeCaptivePortalDetector, "" }
199 };
200
201 #endif
202
203 const Experiment::Choice kImplSidePaintingChoices[] = { 191 const Experiment::Choice kImplSidePaintingChoices[] = {
204 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 192 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
205 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED, 193 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
206 cc::switches::kEnableImplSidePainting, ""}, 194 cc::switches::kEnableImplSidePainting, ""},
207 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 195 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
208 cc::switches::kDisableImplSidePainting, ""} 196 cc::switches::kDisableImplSidePainting, ""}
209 }; 197 };
210 198
211 const Experiment::Choice kDeadlineSchedulingChoices[] = { 199 const Experiment::Choice kDeadlineSchedulingChoices[] = {
212 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 200 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
(...skipping 889 matching lines...) Expand 10 before | Expand all | Expand 10 after
1102 #endif // defined(USE_ASH) 1090 #endif // defined(USE_ASH)
1103 #if defined(OS_CHROMEOS) 1091 #if defined(OS_CHROMEOS)
1104 { 1092 {
1105 "disable-boot-animation", 1093 "disable-boot-animation",
1106 IDS_FLAGS_DISABLE_BOOT_ANIMATION, 1094 IDS_FLAGS_DISABLE_BOOT_ANIMATION,
1107 IDS_FLAGS_DISABLE_BOOT_ANIMATION_DESCRIPTION, 1095 IDS_FLAGS_DISABLE_BOOT_ANIMATION_DESCRIPTION,
1108 kOsCrOSOwnerOnly, 1096 kOsCrOSOwnerOnly,
1109 SINGLE_VALUE_TYPE(chromeos::switches::kDisableBootAnimation), 1097 SINGLE_VALUE_TYPE(chromeos::switches::kDisableBootAnimation),
1110 }, 1098 },
1111 { 1099 {
1112 "captive-portal-detector",
1113 IDS_FLAGS_CAPTIVE_PORTAL_DETECTOR_NAME,
1114 IDS_FLAGS_CAPTIVE_PORTAL_DETECTOR_DESCRIPTION,
1115 kOsCrOSOwnerOnly,
1116 MULTI_VALUE_TYPE(kChromeCaptivePortalDetectionChoices),
1117 },
1118 {
1119 "file-manager-show-checkboxes", 1100 "file-manager-show-checkboxes",
1120 IDS_FLAGS_FILE_MANAGER_SHOW_CHECKBOXES_NAME, 1101 IDS_FLAGS_FILE_MANAGER_SHOW_CHECKBOXES_NAME,
1121 IDS_FLAGS_FILE_MANAGER_SHOW_CHECKBOXES_DESCRIPTION, 1102 IDS_FLAGS_FILE_MANAGER_SHOW_CHECKBOXES_DESCRIPTION,
1122 kOsCrOS, 1103 kOsCrOS,
1123 SINGLE_VALUE_TYPE(chromeos::switches::kFileManagerShowCheckboxes) 1104 SINGLE_VALUE_TYPE(chromeos::switches::kFileManagerShowCheckboxes)
1124 }, 1105 },
1125 { 1106 {
1126 "file-manager-enable-webstore-integration", 1107 "file-manager-enable-webstore-integration",
1127 IDS_FLAGS_FILE_MANAGER_ENABLE_WEBSTORE_INTEGRATION, 1108 IDS_FLAGS_FILE_MANAGER_ENABLE_WEBSTORE_INTEGRATION,
1128 IDS_FLAGS_FILE_MANAGER_ENABLE_WEBSTORE_INTEGRATION_DESCRIPTION, 1109 IDS_FLAGS_FILE_MANAGER_ENABLE_WEBSTORE_INTEGRATION_DESCRIPTION,
(...skipping 1210 matching lines...) Expand 10 before | Expand all | Expand 10 after
2339 } 2320 }
2340 2321
2341 const Experiment* GetExperiments(size_t* count) { 2322 const Experiment* GetExperiments(size_t* count) {
2342 *count = num_experiments; 2323 *count = num_experiments;
2343 return experiments; 2324 return experiments;
2344 } 2325 }
2345 2326
2346 } // namespace testing 2327 } // namespace testing
2347 2328
2348 } // namespace about_flags 2329 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/google_chrome_strings.grd ('k') | chrome/browser/chromeos/login/kiosk_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698