Issue 66713002: Get rid of {Enable|Disable|ChromeCaptivePortalDetector flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 66713002: Get rid of {Enable|Disable|ChromeCaptivePortalDetector flag. (Closed)

Created:
7 years, 1 month ago by ygorshenin1

Modified:
7 years, 1 month ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Get rid of {Enable|Disable|ChromeCaptivePortalDetector flag. BUG=316597 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233944

Patch Set 1 #

Patch Set 2 : Restored blank line. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -56 lines)			Patch
M	chrome/app/chromium_strings.grd	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View		2 chunks	+0 lines, -19 lines	0 comments	Download
M	chrome/browser/chromeos/login/kiosk_browsertest.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/oobe_browsertest.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/net/network_portal_detector.cc	View		2 chunks	+1 line, -6 lines	0 comments	Download
M	chromeos/chromeos_switches.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	chromeos/chromeos_switches.cc	View		2 chunks	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

lgtm To unsubscribe from this group and stop receiving emails from it, send an email ...

7 years, 1 month ago (2013-11-08 14:05:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/66713002/30001

7 years, 1 month ago (2013-11-08 14:08:04 UTC) #3

Message was sent while issue was closed.

Change committed as 233944

Expand Messages | Collapse Messages