Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: remoting/protocol/channel_multiplexer.cc

Issue 667123002: Standardize usage of virtual/override/final in remoting/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/channel_multiplexer.h ('k') | remoting/protocol/chromium_port_allocator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/channel_multiplexer.cc
diff --git a/remoting/protocol/channel_multiplexer.cc b/remoting/protocol/channel_multiplexer.cc
index 0940f76f7d0d91cea65b436a7d85caf4818ea07e..abeb7b217c19bf3b3edf74caec0030bd65040a3f 100644
--- a/remoting/protocol/channel_multiplexer.cc
+++ b/remoting/protocol/channel_multiplexer.cc
@@ -104,73 +104,63 @@ class ChannelMultiplexer::MuxSocket : public net::StreamSocket,
public base::SupportsWeakPtr<MuxSocket> {
public:
MuxSocket(MuxChannel* channel);
- virtual ~MuxSocket();
+ ~MuxSocket() override;
void OnWriteComplete();
void OnWriteFailed();
void OnPacketReceived();
// net::StreamSocket interface.
- virtual int Read(net::IOBuffer* buffer, int buffer_len,
- const net::CompletionCallback& callback) override;
- virtual int Write(net::IOBuffer* buffer, int buffer_len,
- const net::CompletionCallback& callback) override;
-
- virtual int SetReceiveBufferSize(int32 size) override {
+ int Read(net::IOBuffer* buffer,
+ int buffer_len,
+ const net::CompletionCallback& callback) override;
+ int Write(net::IOBuffer* buffer,
+ int buffer_len,
+ const net::CompletionCallback& callback) override;
+
+ int SetReceiveBufferSize(int32 size) override {
NOTIMPLEMENTED();
return net::ERR_NOT_IMPLEMENTED;
}
- virtual int SetSendBufferSize(int32 size) override {
+ int SetSendBufferSize(int32 size) override {
NOTIMPLEMENTED();
return net::ERR_NOT_IMPLEMENTED;
}
- virtual int Connect(const net::CompletionCallback& callback) override {
+ int Connect(const net::CompletionCallback& callback) override {
NOTIMPLEMENTED();
return net::ERR_NOT_IMPLEMENTED;
}
- virtual void Disconnect() override {
- NOTIMPLEMENTED();
- }
- virtual bool IsConnected() const override {
+ void Disconnect() override { NOTIMPLEMENTED(); }
+ bool IsConnected() const override {
NOTIMPLEMENTED();
return true;
}
- virtual bool IsConnectedAndIdle() const override {
+ bool IsConnectedAndIdle() const override {
NOTIMPLEMENTED();
return false;
}
- virtual int GetPeerAddress(net::IPEndPoint* address) const override {
+ int GetPeerAddress(net::IPEndPoint* address) const override {
NOTIMPLEMENTED();
return net::ERR_NOT_IMPLEMENTED;
}
- virtual int GetLocalAddress(net::IPEndPoint* address) const override {
+ int GetLocalAddress(net::IPEndPoint* address) const override {
NOTIMPLEMENTED();
return net::ERR_NOT_IMPLEMENTED;
}
- virtual const net::BoundNetLog& NetLog() const override {
+ const net::BoundNetLog& NetLog() const override {
NOTIMPLEMENTED();
return net_log_;
}
- virtual void SetSubresourceSpeculation() override {
- NOTIMPLEMENTED();
- }
- virtual void SetOmniboxSpeculation() override {
- NOTIMPLEMENTED();
- }
- virtual bool WasEverUsed() const override {
- return true;
- }
- virtual bool UsingTCPFastOpen() const override {
- return false;
- }
- virtual bool WasNpnNegotiated() const override {
- return false;
- }
- virtual net::NextProto GetNegotiatedProtocol() const override {
+ void SetSubresourceSpeculation() override { NOTIMPLEMENTED(); }
+ void SetOmniboxSpeculation() override { NOTIMPLEMENTED(); }
+ bool WasEverUsed() const override { return true; }
+ bool UsingTCPFastOpen() const override { return false; }
+ bool WasNpnNegotiated() const override { return false; }
+ net::NextProto GetNegotiatedProtocol() const override {
return net::kProtoUnknown;
}
- virtual bool GetSSLInfo(net::SSLInfo* ssl_info) override {
+ bool GetSSLInfo(net::SSLInfo* ssl_info) override {
NOTIMPLEMENTED();
return false;
}
« no previous file with comments | « remoting/protocol/channel_multiplexer.h ('k') | remoting/protocol/chromium_port_allocator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698