Use manifest for streamlined hosted app creation for title and URL.

Use manifest for streamlined hosted app creation for title and URL.

This uses the manifest as defined in https://w3c.github.io/manifest/.

BUG=425837
Committed: https://crrev.com/8e992e1bb6c5789e9db040a87ba3eaaf9ac62c9e
Cr-Commit-Position: refs/heads/master@{#300956}

[benwells, 2014-10-22 21:12:28]

benwells@chromium.org changed reviewers:
+ calamity@chromium.org

[calamity, 2014-10-23 02:46:24]

lgtm.

https://codereview.chromium.org/667053007/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/bookmark_app_helper_unittest.cc (right):

https://codereview.chromium.org/667053007/diff/20001/chrome/browser/extension...
chrome/browser/extensions/bookmark_app_helper_unittest.cc:184:
WebApplicationInfo web_app_info;
Maybe also supply a url and name here to ensure they're overwritten by the
manifest. (This is what will happen in the real world, right?)

[benwells, 2014-10-23 03:50:09]

https://codereview.chromium.org/667053007/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/bookmark_app_helper_unittest.cc (right):

https://codereview.chromium.org/667053007/diff/20001/chrome/browser/extension...
chrome/browser/extensions/bookmark_app_helper_unittest.cc:184:
WebApplicationInfo web_app_info;
On 2014/10/23 02:46:24, calamity wrote:
> Maybe also supply a url and name here to ensure they're overwritten by the
> manifest. (This is what will happen in the real world, right?)

OK, I did this in the UpdateWebAppInfoFromManifest test.

[benwells, 2014-10-23 03:50:28]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2014-10-23 03:50:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/667053007/40001

[commit-bot: I haz the power, 2014-10-23 05:30:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 05:30:58]

Try jobs failed on following builders:
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[benwells, 2014-10-23 07:23:35]

benwells@chromium.org changed reviewers:
+ mlamouri@chromium.org

[benwells, 2014-10-23 07:23:35]

mlamouri: please look at change in manifest_manager_host.cc

[mlamouri (slow - plz ping), 2014-10-23 10:28:03]

I wonder if we could make this less error prone by having something like an
owned pointer for CallbackMap*.

lgtm and thanks for fixing this! :)

[benwells, 2014-10-23 20:33:34]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2014-10-23 20:34:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/667053007/60001

[commit-bot: I haz the power, 2014-10-23 21:59:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-23 22:00:23]

Patchset 4 (id:??) landed as
https://crrev.com/8e992e1bb6c5789e9db040a87ba3eaaf9ac62c9e
Cr-Commit-Position: refs/heads/master@{#300956}