Add a flag to ignore autocomplete="off" for Autofill.

components/autofill/core/browser/autofill_external_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_external_delegate.h"
 
+#include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autocomplete_history_manager.h"
 #include "components/autofill/core/browser/autofill_driver.h"
 #include "components/autofill/core/browser/autofill_manager.h"
 #include "components/autofill/core/browser/popup_item_ids.h"
+#include "components/autofill/core/common/autofill_switches.h"
 #include "grit/components_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 
 #if defined(OS_MACOSX) && !defined(OS_IOS)
 namespace {
 
 enum AccessAddressBookEventType {
   // An Autofill entry was shown that prompts the user to give Chrome access to
   // the user's Address Book.
   SHOWED_ACCESS_ADDRESS_BOOK_ENTRY = 0,
@@ skipping 10 matching lines @@
 void EmitHistogram(AccessAddressBookEventType type) {
   UMA_HISTOGRAM_ENUMERATION(
       "Autofill.MacAddressBook", type, ACCESS_ADDRESS_BOOK_ENTRY_MAX);
 }
 
 }  // namespace
 #endif  // defined(OS_MACOSX) && !defined(OS_IOS)
 
 namespace autofill {
 
+namespace {
+
+bool ShouldAutofill(const FormFieldData& form_field) {
+  return form_field.should_autocomplete ||

[Ilya Sherman, 2014/10/21 01:19:11]

nit: Please add parens to support this text alignment, i.e. having the line
below be indented more than four spaces.

[Evan Stade, 2014/10/21 19:12:47]

I'm not sure where you want me to add parens. I'm pretty sure this formatting
was a result of git cl format. I probably would have indented the second line
just 4 spaces.

+         base::CommandLine::ForCurrentProcess()->HasSwitch(
+             switches::kIgnoreAutocompleteOffForAutofill);
+}
+
+}  // namespace
+
 AutofillExternalDelegate::AutofillExternalDelegate(AutofillManager* manager,
                                                    AutofillDriver* driver)
     : manager_(manager),
       driver_(driver),
       query_id_(0),
       display_warning_if_disabled_(false),
       has_suggestion_(false),
       has_shown_popup_for_current_edit_(false),
       has_shown_address_book_prompt(false),
       weak_ptr_factory_(this) {
@@ skipping 245 matching lines @@
                               query_form_,
                               query_field_,
                               unique_id);
 }
 
 void AutofillExternalDelegate::ApplyAutofillWarnings(
     std::vector<base::string16>* values,
     std::vector<base::string16>* labels,
     std::vector<base::string16>* icons,
     std::vector<int>* unique_ids) {
-  if (!query_field_.should_autocomplete) {
+  if (!ShouldAutofill(query_field_)) {
     // Autofill is disabled.  If there were some profile or credit card
     // suggestions to show, show a warning instead.  Otherwise, clear out the
     // list of suggestions.
     if (!unique_ids->empty() && (*unique_ids)[0] > 0) {
       // If Autofill is disabled and we had suggestions, show a warning instead.
       values->assign(
           1, l10n_util::GetStringUTF16(IDS_AUTOFILL_WARNING_FORM_DISABLED));
       labels->assign(1, base::string16());
       icons->assign(1, base::string16());
       unique_ids->assign(1, POPUP_ITEM_ID_WARNING_MESSAGE);
@@ skipping 80 matching lines @@
                      POPUP_ITEM_ID_DATALIST_ENTRY);
 }
 
 #if defined(OS_MACOSX) && !defined(OS_IOS)
 void AutofillExternalDelegate::PingRenderer() {
   driver_->PingRenderer();
 }
 #endif  // defined(OS_MACOSX) && !defined(OS_IOS)
 
 }  // namespace autofill