Add a flag to ignore autocomplete="off" for Autofill.

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 475 matching lines @@
 
     DCHECK_EQ(values.size(), labels.size());
     DCHECK_EQ(values.size(), icons.size());
     DCHECK_EQ(values.size(), unique_ids.size());
 
     if (!values.empty()) {
       // Don't provide Autofill suggestions when Autofill is disabled, and don't
       // provide credit card suggestions for non-HTTPS pages. However, provide a
       // warning to the user in these cases.
       int warning = 0;
-      if (is_filling_credit_card && !FormIsHTTPS(*form_structure))
+      if (is_filling_credit_card && !FormIsHTTPS(*form_structure) &&
+          !CommandLine::ForCurrentProcess()->HasSwitch(
+              "reduce-security-for-testing")) {

[Evan Stade, 2014/10/22 21:52:33]

this is a string literal because the flag is defined in content/ (i.e. no
accessible from this file)

[Ilya Sherman, 2014/10/23 00:35:27]

This seems unrelated to this CL.  I'd honestly prefer not to make this change at
all, but I don't feel strongly about that.  However, I do think that if we want
to make this change, we should (a) split it off into a separate CL, and (b)
access the flag via the embedder interface, rather than using a literal string
here.

[Evan Stade, 2014/10/23 02:02:20]

split this into a separate CL.

         warning = IDS_AUTOFILL_WARNING_INSECURE_CONNECTION;
+      }
       if (warning) {
         values.assign(1, l10n_util::GetStringUTF16(warning));
         labels.assign(1, base::string16());
         icons.assign(1, base::string16());
         unique_ids.assign(1, POPUP_ITEM_ID_WARNING_MESSAGE);
       } else {
         bool section_is_autofilled =
             SectionIsAutofilled(*form_structure, form,
                                 autofill_field->section());
         if (section_is_autofilled) {
@@ skipping 15 matching lines @@
         // The first time we show suggestions on this page, log the number of
         // suggestions shown.
         if (!has_logged_address_suggestions_count_ && !section_is_autofilled) {
           metric_logger_->LogAddressSuggestionsCount(values.size());
           has_logged_address_suggestions_count_ = true;
         }
       }
     }
   }
 
-  // Add the results from AutoComplete.  They come back asynchronously, so we
-  // hand off what we generated and they will send the results back to the
-  // renderer.
-  autocomplete_history_manager_->OnGetAutocompleteSuggestions(
-      query_id, field.name, field.value, field.form_control_type, values,
-      labels, icons, unique_ids);
+  if (field.should_autocomplete) {
+    // Add the results from AutoComplete.  They come back asynchronously, so we
+    // hand off what we generated and they will send the results back to the
+    // renderer.
+    autocomplete_history_manager_->OnGetAutocompleteSuggestions(
+        query_id, field.name, field.value, field.form_control_type, values,
+        labels, icons, unique_ids);
+  } else {
+    // Autocomplete is disabled for this field; only pass back Autofill
+    // suggestions.
+    autocomplete_history_manager_->CancelPendingQuery();
+    external_delegate_->OnSuggestionsReturned(
+        query_id, values, labels, icons, unique_ids);
+  }
 }
 
 void AutofillManager::FillOrPreviewForm(
     AutofillDriver::RendererFormDataAction action,
     int query_id,
     const FormData& form,
     const FormFieldData& field,
     int unique_id) {
   if (!IsValidFormData(form) || !IsValidFormFieldData(field))
     return;
@@ skipping 693 matching lines @@
     return false;
 
   // Disregard forms that we wouldn't ever autofill in the first place.
   if (!form.ShouldBeParsed())
     return false;
 
   return true;
 }
 
 }  // namespace autofill