Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 667033002: Version 3.29.88.10 (merged r24706, r24708) (Closed)

Created:
6 years, 2 months ago by adamk
Modified:
6 years, 2 months ago
Reviewers:
danno
CC:
v8-dev, ulan
Project:
v8
Visibility:
Public.

Description

Version 3.29.88.10 (merged r24706, r24708) Don't expose Array.prototype.values as it breaks webcompat Fix webkit getOwnPropertyNames test after r24706 removed Array.prototype.values BUG=chromium:409858 LOG=N R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -27 lines) Patch
M src/array.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/array-iterator.js View 1 chunk +1 line, -1 line 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/arguments-iterator.js View 3 chunks +10 lines, -10 lines 0 comments Download
M test/mjsunit/es6/array-iterator.js View 6 chunks +7 lines, -10 lines 0 comments Download
M test/mjsunit/es6/typed-array-iterator.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/webkit/fast/js/Object-getOwnPropertyNames.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
adamk
6 years, 2 months ago (2014-10-20 20:39:22 UTC) #1
danno
lgtm
6 years, 2 months ago (2014-10-20 20:54:02 UTC) #2
adamk
6 years, 2 months ago (2014-10-20 21:20:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24748.

Powered by Google App Engine
This is Rietveld 408576698