Increase precision when finding the remainder after division by pi/2.

src/math.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 199 matching lines @@
 }
 
 
 var InitTrigonometricFunctions;
 
 
 // Define constants and interpolation functions.
 // Also define the initialization function that populates the lookup table
 // and then wires up the function definitions.
 function SetupTrigonometricFunctions() {
-  // TODO(yangguo): The following table size has been chosen to satisfy
-  // Sunspider's brittle result verification.  Reconsider relevance.
-  var samples = 4489;
-  var pi = 3.1415926535897932;
-  var pi_half = pi / 2;
-  var inverse_pi_half = 2 / pi;
-  var two_pi = 2 * pi;
-  var four_pi = 4 * pi;
-  var interval = pi_half / samples;
-  var inverse_interval = samples / pi_half;
+  var samples = 1800;   // Table size.  Do not change arbitrarily.
+  // 2 / pi
+  var inverse_pi_half = %HeapNumberFromHex("83c8c96d305fe43f");

[Sven Panne, 2013/11/20 07:38:35]

Why do we need a new %Foo? Our scanner should be able to produce the bit pattern
you want directly from a floating point literal. If not, fix the scanner instead
of introducing a new %Foo.

+  // samples / (pi / 2)
+  var index_convert   = %HeapNumberFromHex("3b597e90a9e79140");
+  // pi / 2 rounded up
+  var pi_half         = %HeapNumberFromHex("192d4454fb21f93f");
+  // We use two parts for pi/2 to emulate a higher precision.
+  // Note that pi_half > pi_half_1 + pi_half_2
+  var pi_half_1       = %HeapNumberFromHex("00000054fb21f93f");
+  var pi_half_2       = %HeapNumberFromHex("3326a611460b113e");
   var table_sin;
   var table_cos_interval;
 
   // This implements sine using the following algorithm.
   // 1) Multiplication takes care of to-number conversion.
   // 2) Reduce x to the first quadrant [0, pi/2].
   //    Conveniently enough, in case of +/-Infinity, we get NaN.
   // 3) Replace x by (pi/2-x) if x was in the 2nd or 4th quadrant.
   // 4) Do a table lookup for the closest samples to the left and right of x.
   // 5) Find the derivatives at those sampling points by table lookup:
   //    dsin(x)/dx = cos(x) = sin(pi/2-x) for x in [0, pi/2].
   // 6) Use cubic spline interpolation to approximate sin(x).
   // 7) Negate the result if x was in the 3rd or 4th quadrant.
   // 8) Get rid of -0 by adding 0.
-  var Interpolation = function(x) {
-    var double_index = x * inverse_interval;
+  var Interpolation = function(x, phase) {
+    var double_index = x * index_convert;
+    if (phase & 1) double_index = samples - double_index;
     var index = double_index | 0;
     var t1 = double_index - index;
     var t2 = 1 - t1;
     var y1 = table_sin[index];
     var y2 = table_sin[index + 1];
     var dy = y2 - y1;
     return (t2 * y1 + t1 * y2 +
                 t1 * t2 * ((table_cos_interval[index] - dy) * t2 +
-                           (dy - table_cos_interval[index + 1]) * t1));
+                           (dy - table_cos_interval[index + 1]) * t1))
+           * (1 - (phase & 2)) + 0;
   }
 
   var MathSinInterpolation = function(x) {
-    // This is to make Sunspider's result verification happy.
-    if (x > four_pi) x -= four_pi;
-    var multiple = MathFloor(x * inverse_pi_half);
-    if (%_IsMinusZero(multiple)) return multiple;
-    x = (multiple & 1) * pi_half +
-        (1 - ((multiple & 1) << 1)) * (x - multiple * pi_half);
-    return Interpolation(x) * (1 - (multiple & 2)) + 0;
+    var x_over_pi_half = x * inverse_pi_half;
+    if (%_IsMinusZero(x_over_pi_half)) return x_over_pi_half;
+    var phase = 0;
+    while (x < 0 || x > pi_half) {
+      var multiple = MathFloor(x * inverse_pi_half);
+      x = x - multiple * pi_half_1 - multiple * pi_half_2;
+      phase += multiple;
+    }
+    return Interpolation(x, multiple);
   }
 
   // Cosine is sine with a phase offset of pi/2.
   var MathCosInterpolation = function(x) {
-    var multiple = MathFloor(x * inverse_pi_half);
-    var phase = multiple + 1;
-    x = (phase & 1) * pi_half +
-        (1 - ((phase & 1) << 1)) * (x - multiple * pi_half);
-    return Interpolation(x) * (1 - (phase & 2)) + 0;
+    x = MathAbs(x);
+    var phase = 0;
+    while (x < 0 || x > pi_half) {
+      var multiple = MathFloor(x * inverse_pi_half);
+      x = x - multiple * pi_half_1 - multiple * pi_half_2;
+      phase += multiple;
+    }
+    return Interpolation(x, phase + 1);
   };
 
   %SetInlineBuiltinFlag(Interpolation);
   %SetInlineBuiltinFlag(MathSinInterpolation);
   %SetInlineBuiltinFlag(MathCosInterpolation);
 
   InitTrigonometricFunctions = function() {
     table_sin = new global.Float64Array(samples + 2);
     table_cos_interval = new global.Float64Array(samples + 2);
     %PopulateTrigonometricTable(table_sin, table_cos_interval, samples);
@@ skipping 77 matching lines @@
     "min", MathMin,
     "imul", MathImul
   ));
 
   %SetInlineBuiltinFlag(MathSin);
   %SetInlineBuiltinFlag(MathCos);
   %SetInlineBuiltinFlag(MathTan);
 }
 
 SetUpMath();