Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 667023005: Resolve old TODO. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ssl/ssl_blocking_page.h" 5 #include "chrome/browser/ssl/ssl_blocking_page.h"
6 6
7 #include "base/build_time.h" 7 #include "base/build_time.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/i18n/rtl.h" 9 #include "base/i18n/rtl.h"
10 #include "base/i18n/time_formatting.h" 10 #include "base/i18n/time_formatting.h"
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 l10n_util::GetStringUTF8(IDS_OPTIONS_SETTINGS_SECTION_TITLE_DATETIME); 225 l10n_util::GetStringUTF8(IDS_OPTIONS_SETTINGS_SECTION_TITLE_DATETIME);
226 chrome::ShowSettingsSubPageForProfile( 226 chrome::ShowSettingsSubPageForProfile(
227 ProfileManager::GetActiveUserProfile(), sub_page); 227 ProfileManager::GetActiveUserProfile(), sub_page);
228 return; 228 return;
229 #elif defined(OS_ANDROID) 229 #elif defined(OS_ANDROID)
230 CommandLine command(base::FilePath("/system/bin/am")); 230 CommandLine command(base::FilePath("/system/bin/am"));
231 command.AppendArg("start"); 231 command.AppendArg("start");
232 command.AppendArg( 232 command.AppendArg(
233 "'com.android.settings/.Settings$DateTimeSettingsActivity'"); 233 "'com.android.settings/.Settings$DateTimeSettingsActivity'");
234 #elif defined(OS_IOS) 234 #elif defined(OS_IOS)
235 // Apparently, iOS really does not have a way to launch the date and time 235 // iOS does not have a way to launch the date and time settings.
236 // settings. Weird. TODO(palmer): Do something more graceful than ignoring
237 // the user's click! crbug.com/394993
238 return; 236 return;
239 #elif defined(OS_LINUX) 237 #elif defined(OS_LINUX)
240 struct ClockCommand { 238 struct ClockCommand {
241 const char* pathname; 239 const char* pathname;
242 const char* argument; 240 const char* argument;
243 }; 241 };
244 static const ClockCommand kClockCommands[] = { 242 static const ClockCommand kClockCommands[] = {
245 // GNOME 243 // GNOME
246 // 244 //
247 // NOTE: On old Ubuntu, naming control panels doesn't work, so it 245 // NOTE: On old Ubuntu, naming control panels doesn't work, so it
(...skipping 422 matching lines...) Expand 10 before | Expand all | Expand 10 after
670 for (; i < 5; i++) { 668 for (; i < 5; i++) {
671 strings->SetString(keys[i], std::string()); 669 strings->SetString(keys[i], std::string());
672 } 670 }
673 } 671 }
674 672
675 void SSLBlockingPage::OnGotHistoryCount(bool success, 673 void SSLBlockingPage::OnGotHistoryCount(bool success,
676 int num_visits, 674 int num_visits,
677 base::Time first_visit) { 675 base::Time first_visit) {
678 num_visits_ = num_visits; 676 num_visits_ = num_visits;
679 } 677 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698