Issue 667023004: Remove unnecessary ServeFilesFromDirectory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 667023004: Remove unnecessary ServeFilesFromDirectory (Closed)

Created:
6 years, 2 months ago by nasko

Modified:
6 years, 2 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Remove unnecessary ServeFilesFromDirectory BUG= Committed: https://crrev.com/60f67cb9cce431ac2d56e96448bc1b5090399d52 Cr-Commit-Position: refs/heads/master@{#300608}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	content/browser/site_per_process_browsertest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	content/test/browser_test_utils_browsertest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

nasko

Hey Nick, Can you review this one? Thanks for catching it! Thanks, Nasko

6 years, 2 months ago (2014-10-21 23:05:37 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667023004/1

6 years, 2 months ago (2014-10-21 23:31:35 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-22 04:05:04 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/60f67cb9cce431ac2d56e96448bc1b5090399d52
Cr-Commit-Position: refs/heads/master@{#300608}