Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 667023002: Revert of Replace SkTypeface::Style with SkFontStyle. (Closed)

Created:
6 years, 2 months ago by mtklein
Modified:
6 years, 2 months ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Replace SkTypeface::Style with SkFontStyle. (patchset #9 id:160001 of https://codereview.chromium.org/488143002/) Reason for revert: CrOS GM failures: [*] 2 ExpectationsMismatch: fontmgr_iter_565.png fontmgr_iter_8888.png Original issue's description: > Replace SkTypeface::Style with SkFontStyle. > > Committed: https://skia.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 TBR=reed@google.com,bungeman@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/802ad83dca2efd57fde6c7ba666555ea78b5324c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+404 lines, -369 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/ports.gyp View 1 chunk +1 line, -0 lines 0 comments Download
D include/core/SkFontStyle.h View 1 chunk +0 lines, -72 lines 0 comments Download
M include/core/SkTypeface.h View 4 chunks +13 lines, -22 lines 0 comments Download
A include/ports/SkFontStyle.h View 1 chunk +70 lines, -0 lines 0 comments Download
M src/core/SkFontHost.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/core/SkTypeface.cpp View 2 chunks +21 lines, -5 lines 0 comments Download
M src/core/SkTypefaceCache.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkTypefaceCache.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/fonts/SkFontMgr_fontconfig.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/fonts/SkGScalerContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/fonts/SkTestScalerContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/fonts/SkTestScalerContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkFontConfigTypeface.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 2 chunks +5 lines, -48 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_fontconfig.cpp View 2 chunks +17 lines, -21 lines 0 comments Download
M src/ports/SkFontHost_linux.cpp View 7 chunks +11 lines, -10 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 19 chunks +168 lines, -114 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 9 chunks +34 lines, -20 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 6 chunks +13 lines, -6 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 5 chunks +13 lines, -6 lines 0 comments Download
M src/ports/SkFontMgr_win_dw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkTypeface_win_dw.h View 2 chunks +14 lines, -10 lines 0 comments Download
M tools/sk_tool_utils_font.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Replace SkTypeface::Style with SkFontStyle.
6 years, 2 months ago (2014-10-20 19:53:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667023002/1
6 years, 2 months ago (2014-10-20 19:54:08 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 19:54:36 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 802ad83dca2efd57fde6c7ba666555ea78b5324c

Powered by Google App Engine
This is Rietveld 408576698