Chromium Code Reviews

Issue 667013003: Disable direct write if font count in registry is greater than or equal to threshold (currently 175… (Closed)

Created:
6 years, 2 months ago by Shrikant Kelkar
Modified:
6 years, 2 months ago
Reviewers:
ananta, cpu_(ooo_6.6-7.5), Alexei Svitkine (slow), scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable direct write if font count in registry is greater than or equal to threshold (currently 1750). R=scottmg,ananta,cpu,asvitkine BUG=421305 Committed: https://crrev.com/e2607d44b9384080b7a98e0b7ed9773265969d87 Cr-Commit-Position: refs/heads/master@{#300345}

Patch Set 1 #

Patch Set 2 : If it is hidpi then we will not use GDI irrespective of number of fonts. #

Total comments: 2

Patch Set 3 : Added comment as per code review suggestion. #

Unified diffs Side-by-side diffs Stats (+15 lines, -0 lines)
M ui/gfx/win/direct_write.cc View 2 chunks +15 lines, -0 lines 0 comments

Messages

Total messages: 12 (2 generated)
Shrikant Kelkar
6 years, 2 months ago (2014-10-20 19:34:34 UTC) #1
Shrikant Kelkar
Moved after hidpi check. ptal.
6 years, 2 months ago (2014-10-20 19:46:39 UTC) #2
scottmg
lgtm
6 years, 2 months ago (2014-10-20 19:54:37 UTC) #3
Shrikant Kelkar
+ asvitkine for OWNERS
6 years, 2 months ago (2014-10-20 19:56:19 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/667013003/diff/20001/ui/gfx/win/direct_write.cc File ui/gfx/win/direct_write.cc (right): https://codereview.chromium.org/667013003/diff/20001/ui/gfx/win/direct_write.cc#newcode42 ui/gfx/win/direct_write.cc:42: const wchar_t kWindowsFontsRegistryKey[] = lets add a comment ...
6 years, 2 months ago (2014-10-20 20:01:10 UTC) #6
Alexei Svitkine (slow)
lgtm
6 years, 2 months ago (2014-10-20 20:06:11 UTC) #7
Shrikant Kelkar
https://codereview.chromium.org/667013003/diff/20001/ui/gfx/win/direct_write.cc File ui/gfx/win/direct_write.cc (right): https://codereview.chromium.org/667013003/diff/20001/ui/gfx/win/direct_write.cc#newcode42 ui/gfx/win/direct_write.cc:42: const wchar_t kWindowsFontsRegistryKey[] = On 2014/10/20 20:01:10, cpu wrote: ...
6 years, 2 months ago (2014-10-20 20:14:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667013003/40001
6 years, 2 months ago (2014-10-20 20:16:55 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-20 22:03:17 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 22:04:03 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e2607d44b9384080b7a98e0b7ed9773265969d87
Cr-Commit-Position: refs/heads/master@{#300345}

Powered by Google App Engine