Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1793)

Unified Diff: content/browser/service_worker/service_worker_url_request_job.cc

Issue 666973003: [ServiceWorker] Don't send the UMA related headers to the ServiceWorker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: introudce ServiceWorkerContext::AddExcludedHeaderNameForFetchEvent Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_url_request_job.cc
diff --git a/content/browser/service_worker/service_worker_url_request_job.cc b/content/browser/service_worker/service_worker_url_request_job.cc
index a041426213c33d26ee4ef0b1e841fa9517cfe23a..63cfa0d0e17f66c592b5e2c0b8263bfcc6d710ec 100644
--- a/content/browser/service_worker/service_worker_url_request_job.cc
+++ b/content/browser/service_worker/service_worker_url_request_job.cc
@@ -18,6 +18,7 @@
#include "content/common/service_worker/service_worker_types.h"
#include "content/public/browser/blob_handle.h"
#include "content/public/browser/resource_request_info.h"
+#include "content/public/browser/service_worker_context.h"
#include "net/base/net_errors.h"
#include "net/http/http_request_headers.h"
#include "net/http/http_response_headers.h"
@@ -30,17 +31,6 @@
namespace content {
-namespace {
-
-// Keep in sync with kDevToolsRequestInitiator and
-// kDevToolsEmulateNetworkConditionsClientId defined in
-// devtools_network_transaction.cc and InspectorResourceAgent.cpp.
-const char kDevToolsRequestInitiator[] = "X-DevTools-Request-Initiator";
-const char kDevToolsEmulateNetworkConditionsClientId[] =
- "X-DevTools-Emulate-Network-Conditions-Client-Id";
-
-} // namespace
-
ServiceWorkerURLRequestJob::ServiceWorkerURLRequestJob(
net::URLRequest* request,
net::NetworkDelegate* network_delegate,
@@ -299,8 +289,7 @@ ServiceWorkerURLRequestJob::CreateFetchRequest() {
request->method = request_->method();
const net::HttpRequestHeaders& headers = request_->extra_request_headers();
for (net::HttpRequestHeaders::Iterator it(headers); it.GetNext();) {
- if (it.name() == kDevToolsRequestInitiator ||
- it.name() == kDevToolsEmulateNetworkConditionsClientId) {
+ if (ServiceWorkerContext::IsExcludedHeaderNameForFetchEvent(it.name())) {
Alexei Svitkine (slow) 2014/10/27 15:09:00 Nit: No {}'s since body fits one line.
horo 2014/10/28 02:35:05 Done.
continue;
}
request->headers[it.name()] = it.value();

Powered by Google App Engine
This is Rietveld 408576698