Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: content/public/browser/service_worker_context.h

Issue 666973003: [ServiceWorker] Don't send the UMA related headers to the ServiceWorker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use const ref Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/service_worker_context.h
diff --git a/content/public/browser/service_worker_context.h b/content/public/browser/service_worker_context.h
index e035fbec34ed0a4213bce2dcce0ffdae2c55f83a..a96f7797506cb1ecb89aaff23d22d907fdb7b03a 100644
--- a/content/public/browser/service_worker_context.h
+++ b/content/public/browser/service_worker_context.h
@@ -5,6 +5,10 @@
#ifndef CONTENT_PUBLIC_BROWSER_SERVICE_WORKER_CONTEXT_H_
#define CONTENT_PUBLIC_BROWSER_SERVICE_WORKER_CONTEXT_H_
+#include <set>
no sievers 2014/10/29 21:19:58 set is unused
horo 2014/10/30 07:54:35 Done.
+#include <string>
+#include <vector>
+
#include "base/basictypes.h"
#include "base/callback_forward.h"
#include "content/public/browser/service_worker_usage_info.h"
@@ -13,7 +17,7 @@
namespace content {
// Represents the per-StoragePartition ServiceWorker data. Must be used from
-// the IO thread.
+// the IO thread except for AddExcludedHeadersForFetchEvent.
Lei Zhang 2014/10/29 21:47:21 With the code as is, do you mean to say "except fo
horo 2014/10/30 07:54:34 Yes but the sentence "Must be used from the IO thr
class ServiceWorkerContext {
public:
// https://rawgithub.com/slightlyoff/ServiceWorker/master/spec/service_worker/index.html#url-scope:
@@ -25,6 +29,13 @@ class ServiceWorkerContext {
typedef base::Callback<void(const std::vector<ServiceWorkerUsageInfo>&
usage_info)> GetUsageInfoCallback;
+ // Registers the header name which should not be passed to the ServiceWorker.
+ CONTENT_EXPORT static void AddExcludedHeadersForFetchEvent(
+ const std::vector<std::string>& header_names);
+
+ // Returns true if the header name should not be passed to the ServiceWorker.
+ static bool IsExcludedHeaderNameForFetchEvent(const std::string& header_name);
+
// Equivalent to calling navigator.serviceWorker.register(script_url, {scope:
// pattern}) from a renderer, except that |pattern| is an absolute URL instead
// of relative to some current origin. |callback| is passed true when the JS

Powered by Google App Engine
This is Rietveld 408576698