Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1957)

Unified Diff: content/browser/service_worker/service_worker_url_request_job.cc

Issue 666973003: [ServiceWorker] Don't send the UMA related headers to the ServiceWorker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_url_request_job.cc
diff --git a/content/browser/service_worker/service_worker_url_request_job.cc b/content/browser/service_worker/service_worker_url_request_job.cc
index a041426213c33d26ee4ef0b1e841fa9517cfe23a..a926622387da0bc9af0c9825a9ce58ec35903cb1 100644
--- a/content/browser/service_worker/service_worker_url_request_job.cc
+++ b/content/browser/service_worker/service_worker_url_request_job.cc
@@ -39,6 +39,10 @@ const char kDevToolsRequestInitiator[] = "X-DevTools-Request-Initiator";
const char kDevToolsEmulateNetworkConditionsClientId[] =
"X-DevTools-Emulate-Network-Conditions-Client-Id";
+// Keep in sync with variations_http_header_provider.cc.
michaeln 2014/10/22 22:19:40 Having to manually keep these files in sysnc is pr
Alexei Svitkine (slow) 2014/10/24 15:35:48 Agreed. I think we probably want to have a IsVari
michaeln 2014/10/24 19:49:50 The content lib cannot depend on variations compon
horo 2014/10/27 14:15:40 Ah. I didn't notice that there is 'variations_http
+const char kChromeUMAEnabled[] = "X-Chrome-UMA-Enabled";
+const char kClientData[] = "X-Client-Data";
+
} // namespace
ServiceWorkerURLRequestJob::ServiceWorkerURLRequestJob(
@@ -300,7 +304,9 @@ ServiceWorkerURLRequestJob::CreateFetchRequest() {
const net::HttpRequestHeaders& headers = request_->extra_request_headers();
for (net::HttpRequestHeaders::Iterator it(headers); it.GetNext();) {
if (it.name() == kDevToolsRequestInitiator ||
- it.name() == kDevToolsEmulateNetworkConditionsClientId) {
+ it.name() == kDevToolsEmulateNetworkConditionsClientId ||
+ it.name() == kChromeUMAEnabled ||
+ it.name() == kClientData) {
continue;
}
request->headers[it.name()] = it.value();

Powered by Google App Engine
This is Rietveld 408576698