[ServiceWorker] Don't send the UMA related headers to the ServiceWorker.

content/public/browser/service_worker_context.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/public/browser/service_worker_context.h"
+
+#include "base/bind.h"
+#include "base/lazy_instance.h"
+#include "content/public/browser/browser_thread.h"
+
+namespace content {
+
+namespace {
+
+typedef std::set<std::string> HeaderNameSet;
+static base::LazyInstance<HeaderNameSet> g_excluded_header_name_set =

[Lei Zhang, 2014/10/29 21:47:21]

you: you don't need static in an anonymous namespace.

[horo, 2014/10/30 07:54:34]

Done.

+    LAZY_INSTANCE_INITIALIZER;
+}
+

[no sievers, 2014/10/29 21:19:58]

Do you think the static functions could move to the impl class?
It's a bit discouraged by the content api guide to have .cc files for this.

[horo, 2014/10/30 07:54:34]

ServiceWorkerContextWrapper which is the impl class of ServiceWorkerContext is
created on UI thread per StoragePartition.
It is difficult to get ServiceWorkerContextWrapper from where I want to call
AddExcludedHeadersForFetchEven on IO thread.

Shall I move this file to content/browser/ directory like browser_context.cc?

[no sievers, 2014/10/30 19:35:33]

Oh I meant just literally moving the definition of the function (and leaving the
declaration as is if you need it to be public). I.e. define static
Interface::Foo() in interface_impl.cc. Also see other static functions in
content/public/browser where the same is done like
RenderWidgetHostView::FromID().

+void ServiceWorkerContext::AddExcludedHeadersForFetchEvent(
+    const std::vector<std::string>& header_names) {
+  if (!BrowserThread::CurrentlyOn(BrowserThread::IO)) {
+    BrowserThread::PostTask(

[no sievers, 2014/10/29 21:19:58]

Could you let the caller handle that? Then you can leave the API like it is i.e.
IO-thread only, see header comment.

[horo, 2014/10/30 07:54:34]

Done.

+        BrowserThread::IO,
+        FROM_HERE,
+        base::Bind(ServiceWorkerContext::AddExcludedHeadersForFetchEvent,
+                   header_names));
+    return;
+  }
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+  g_excluded_header_name_set.Get().insert(header_names.begin(),
+                                          header_names.end());
+}
+
+bool ServiceWorkerContext::IsExcludedHeaderNameForFetchEvent(
+    const std::string& header_name) {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+  return g_excluded_header_name_set.Get().find(header_name) !=
+         g_excluded_header_name_set.Get().end();
+}
+
+}  // namespace content