Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 666963002: DevTools: use installDragHandle to pan/rotate in Layers3DView (Closed)

Created:
6 years, 2 months ago by caseq
Modified:
6 years, 2 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: use installDragHandle to pan/rotate in Layers3DView We used to use hand-crafter mouse-up/move/down event processing to control layer 3d view pan/rotate which caused annoying text selection when mouse was moved out of original view. Let's use WebInspector.installDragHandle instead. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -29 lines) Patch
M Source/devtools/front_end/timeline/TransformController.js View 4 chunks +9 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caseq
6 years, 2 months ago (2014-10-20 15:13:13 UTC) #2
caseq
ping
6 years, 2 months ago (2014-10-22 12:59:30 UTC) #3
vsevik
lgtm
6 years, 2 months ago (2014-10-23 08:00:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666963002/1
6 years, 2 months ago (2014-10-23 08:01:21 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 08:56:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184247

Powered by Google App Engine
This is Rietveld 408576698