Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: build/config/BUILDCONFIG.gn

Issue 666813002: GN: Fix Android component build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-clank
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILD.gn ('k') | cc/surfaces/BUILD.gn » ('j') | chrome/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILDCONFIG.gn
diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
index 890d33e0659e0d0b9ed1bf41b5e572979742b177..4dd85f37b184de48de08b6ede200d86d29947115 100644
--- a/build/config/BUILDCONFIG.gn
+++ b/build/config/BUILDCONFIG.gn
@@ -26,7 +26,7 @@ declare_args() {
symbol_level = -1
# Component build.
- is_component_build = false
+ is_component_build = os == "android"
jamesr 2014/10/20 23:11:24 huh? why would this be the default? the production
cjhopman 2014/10/21 00:19:06 Yeah, the production builds also have is_debug = f
# Debug build.
is_debug = true
« no previous file with comments | « build/config/BUILD.gn ('k') | cc/surfaces/BUILD.gn » ('j') | chrome/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698