GN: Fix Android component build

components/dom_distiller/core/BUILD.gn

Index: components/dom_distiller/core/BUILD.gn
diff --git a/components/dom_distiller/core/BUILD.gn b/components/dom_distiller/core/BUILD.gn
index e20a4add243f8118d0988062e413d21ce63da5ce..be5816e4c6970f7d0efa3a3b8b8c36fe90e3803c 100644
--- a/components/dom_distiller/core/BUILD.gn
+++ b/components/dom_distiller/core/BUILD.gn
@@ -3,7 +3,7 @@
 # found in the LICENSE file.
 
 # GYP version: components/dom_distiller.gypi:dom_distiller_core
-static_library("core") {
+source_set("core") {

[blundell, 2014/10/27 07:10:39]

why this change?

[jamesr, 2014/10/27 07:14:46]

static_library is nearly always wrong in GN in chromium unless there's a very
specific need for it, which there doesn't appear to be here.

[blundell, 2014/10/27 07:31:47]

IIUC, source_set means "fold the .o's in this target into the library of the
target that depends on this target." Is that correct? I would have expected to
see this replaced by "component". I'm not super-familiar with gn yet though.

[cjhopman, 2014/10/27 07:32:07]

Yeah, as james said.

This isn't actually needed to make linking work... I just reflexively fixed it
as I was changing this target.

   sources = [
     "../android/component_jni_registrar.cc",
     "../android/component_jni_registrar.h",
@@ -63,6 +63,10 @@ static_library("core") {
   ]
 
   if (is_android) {
+    sources += [
+      "dom_distiller_service_android.cc",
+      "dom_distiller_service_android.h",
+    ]
     deps += [ ":jni_headers" ]
   }
 }