Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/bookmarks.gypi

Issue 666813002: GN: Fix Android component build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-clank
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/renderer/BUILD.gn ('K') | « chrome/renderer/BUILD.gn ('k') | components/bookmarks/common/BUILD.gn » ('j') | content/app/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/bookmarks.gypi
diff --git a/components/bookmarks.gypi b/components/bookmarks.gypi
index b9a72687cb5911065126faaaf33669e081c33d9c..fdf382d81c58de4f660006acf63cb83bda9942f9 100644
--- a/components/bookmarks.gypi
+++ b/components/bookmarks.gypi
@@ -60,6 +60,9 @@
],
'conditions': [
['OS == "android"', {
+ # In GN, this android-specific stuff is its own target at
+ # //components/bookmarks/common/android
+ # TODO(cjhopman): This should be its own target in Gyp, too.
'dependencies': [
'bookmarks_jni_headers',
],
« chrome/renderer/BUILD.gn ('K') | « chrome/renderer/BUILD.gn ('k') | components/bookmarks/common/BUILD.gn » ('j') | content/app/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698