third_party/cld/BUILD.gn - Issue 666813002: GN: Fix Android component build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/cld/BUILD.gn

Issue 666813002: GN: Fix Android component build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-clank

Patch Set: Actually undo gyp change Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/cld/BUILD.gn

diff --git a/third_party/cld/BUILD.gn b/third_party/cld/BUILD.gn

index 30af5b8acc9034dbfb47a1081f2727335ac353eb..188cdd792415fac6e7b0f88b520945c1a79bfbae 100644

--- a/third_party/cld/BUILD.gn

+++ b/third_party/cld/BUILD.gn

@@ -7,7 +7,8 @@ config("cld_config") {

include_dirs = [ "." ]

}

-static_library("cld") {

+source_set("cld") {

+ set_sources_assignment_filter([])

jamesr 2014/10/22 00:28:19 why do you need this? do we use the windows code o

cjhopman 2014/10/23 00:15:48 We do. In gyp, we actually only apply the filenam

# This target includes its own copy of "base" which confuses the header

# checker.

check_includes = false