Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: chrome/browser/sync/test/integration/sync_errors_test.cc

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/sync_errors_test.cc
diff --git a/chrome/browser/sync/test/integration/sync_errors_test.cc b/chrome/browser/sync/test/integration/sync_errors_test.cc
index 3771f69c8a31b0380512de56755448461b8ef403..2493260382ca17b964e11264c46e959a3ff97d07 100644
--- a/chrome/browser/sync/test/integration/sync_errors_test.cc
+++ b/chrome/browser/sync/test/integration/sync_errors_test.cc
@@ -27,14 +27,12 @@ class SyncDisabledChecker : public SingleClientStatusChangeChecker {
explicit SyncDisabledChecker(ProfileSyncService* service)
: SingleClientStatusChangeChecker(service) {}
- virtual bool IsExitConditionSatisfied() override {
+ bool IsExitConditionSatisfied() override {
return !service()->setup_in_progress() &&
!service()->HasSyncSetupCompleted();
}
- virtual std::string GetDebugMessage() const override {
- return "Sync Disabled";
- }
+ std::string GetDebugMessage() const override { return "Sync Disabled"; }
};
class TypeDisabledChecker : public SingleClientStatusChangeChecker {
@@ -43,13 +41,11 @@ class TypeDisabledChecker : public SingleClientStatusChangeChecker {
syncer::ModelType type)
: SingleClientStatusChangeChecker(service), type_(type) {}
- virtual bool IsExitConditionSatisfied() override {
+ bool IsExitConditionSatisfied() override {
return !service()->GetActiveDataTypes().Has(type_);
}
- virtual std::string GetDebugMessage() const override {
- return "Type disabled";
- }
+ std::string GetDebugMessage() const override { return "Type disabled"; }
private:
syncer::ModelType type_;
};
@@ -82,18 +78,18 @@ class ActionableErrorChecker : public SingleClientStatusChangeChecker {
explicit ActionableErrorChecker(ProfileSyncService* service)
: SingleClientStatusChangeChecker(service) {}
- virtual ~ActionableErrorChecker() {}
+ ~ActionableErrorChecker() override {}
// Checks if an actionable error has been hit. Called repeatedly each time PSS
// notifies observers of a state change.
- virtual bool IsExitConditionSatisfied() override {
+ bool IsExitConditionSatisfied() override {
ProfileSyncService::Status status;
service()->QueryDetailedSyncStatus(&status);
return (status.sync_protocol_error.action != syncer::UNKNOWN_ACTION &&
service()->HasUnrecoverableError());
}
- virtual std::string GetDebugMessage() const override {
+ std::string GetDebugMessage() const override {
return "ActionableErrorChecker";
}

Powered by Google App Engine
This is Rietveld 408576698