chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc - Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc ('k') | chrome/browser/sync/test/integration/single_client_status_change_checker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc

diff --git a/chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc b/chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc

index b819a80eafb24cefccb61fbdb2b652d8dc688874..bf6b34c8eae34301e0739c7be4489e1545a4e0bd 100644

--- a/chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc

+++ b/chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc

@@ -82,7 +82,7 @@ class SyncBackendStoppedChecker : public ProfileSyncServiceBase::Observer {

timeout_(TestTimeouts::action_max_timeout()),

done_(false) {}

- virtual void OnStateChanged() override {

+ void OnStateChanged() override {

if (ProfileSyncService::IDLE == pss_->backend_mode()) {

done_ = true;

run_loop_.Quit();

@@ -121,7 +121,7 @@ class SyncRollbackChecker : public ProfileSyncServiceBase::Observer,

clear_done_(false) {}

// ProfileSyncServiceBase::Observer implementation.

- virtual void OnStateChanged() override {

+ void OnStateChanged() override {

if (ProfileSyncService::ROLLBACK == pss_->backend_mode()) {

rollback_started_ = true;

if (clear_done_)

@@ -130,7 +130,7 @@ class SyncRollbackChecker : public ProfileSyncServiceBase::Observer,

}

// BrowsingDataRemoverObserver::Observer implementation.

- virtual void OnBrowsingDataRemoverDone() override {

+ void OnBrowsingDataRemoverDone() override {

clear_done_ = true;

if (rollback_started_) {

run_loop_.Quit();